fix(client): deduplicate messages / lower case join code #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
previously approved these changes
Aug 21, 2024
| const currentTimestamp = this._lastSpotState && this._lastSpotState.timestamp; | ||
|
|
||
| if (currentTimestamp && timestamp && currentTimestamp >= timestamp) { | ||
| const previousMsgId = this._lastSpotState && this._lastSpotState.msgId; |
| @@ -272,7 +275,7 @@ export class RemoteControlServer extends BaseRemoteControlService { | |||
| * @returns {Promise} - A Promise resolved when the code has been refreshed. | |||
| */ | |||
| refreshJoinCodeWithXmpp() { | |||
| const roomLock = generateRandomString(3); | |||
| const roomLock = generateRandomString(3).toLowerCase(); | |||
There was a problem hiding this comment.
I don't think the passcode needs to be lowercase, does it?
There was a problem hiding this comment.
It's not that the passcode needs to be lowercase, but when you enter it on the remote, even if the ui shows them as upper case it does a toLowerCase() and then sends it to the server.
| @@ -82,7 +85,7 @@ export class RemoteControlServer extends BaseRemoteControlService { | |||
| // If there's no joinCode service then create a room and let the lock | |||
| // be set later. Setting the lock on join will throw an error about | |||
| // not being authorized.. | |||
| roomName: generateRandomString(3) | |||
| roomName: generateRandomString(3).toLowerCase() | |||
There was a problem hiding this comment.
What about above, when we split a 6 digit code?
saghul
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.