Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lang): update German translations #15500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(lang): update German translations #15500

wants to merge 1 commit into from
+9 −1

Conversation

stefanzugal
Copy link

Update missing translations for German.

CLA is already signed for corporation Evaluation Software Development.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul saghul requested a review from csett86 January 17, 2025 09:20
@saghul
Copy link
Member

saghul commented Jan 17, 2025

Paging @csett86 :-)

csett86
csett86 requested changes Feb 2, 2025
View reviewed changes
Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates to the German translation. Just smaller corrections to have it fit to the existing translations, I suggested them inline

lang/main-de.json
@@ -334,6 +334,7 @@
"kickParticipantButton": "Entfernen",
"kickParticipantDialog": "Wollen Sie diese Person wirklich entfernen?",
"kickParticipantTitle": "Person entfernen?",
"kickSystemTitle": "Autsch! Sie wurden aus dem Meeting geworfen",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"kickSystemTitle": "Autsch! Sie wurden aus dem Meeting geworfen",
"kickSystemTitle": "Autsch! Sie wurden aus der Konferenz geworfen",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for clarification! I used the term "Meeting" as the following existing translation uses it as well:

"kickTitle": "Autsch! {{participantDisplayName}} hat Sie aus dem Meeting geworfen",

I have seen that there are more other translations that use the term "Meeting" as well. Should I also adapt them?From what I see, it should be not too much work to adapt.

lang/main-de.json
@@ -1176,6 +1183,7 @@
"fearful": "Ängstlich",
"happy": "Fröhlich",
"hours": "{{count}} Std. ",
"labelTooltip": "Anzahl der Teilnehmer: {{count}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"labelTooltip": "Anzahl der Teilnehmer: {{count}}",
"labelTooltip": "Anzahl der Personen: {{count}}",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for the comment above. Should I only adapt this single occurrence - or all occurrences for "Teilnehmer"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csett86 csett86 csett86 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanzugal @jitsi-jenkins @saghul @csett86