Created valid structure for audio menu #16007
Conversation
|
Hi, thanks for your contribution! |
raduanastase8x8
force-pushed
the
audio-menu-structure
branch
from
a8f1575 to
7b3480b
Compare
|
@Calinteodor can you PTAL? |
| @@ -232,7 +232,7 @@ const ContextMenuItem = ({ | |||
| <div | |||
| aria-controls = { controls } | |||
| aria-disabled = { disabled } | |||
| aria-label = { accessibilityLabel } | |||
| aria-label = { accessibilityLabel || undefined } | |||
There was a problem hiding this comment.
do we need to specify undefined?
| @@ -135,39 +135,38 @@ const SpeakerEntry = (props: IProps) => { | |||
| } | |||
|
|
|||
| const { children, isSelected, index, length } = props; | |||
| const testLabel = 'Test'; | |||
There was a problem hiding this comment.
think we usually i18n those as well. seems it was not the case for this one though :) Think you can add it to translates?
| tabIndex = { -1 }> | ||
| <ContextMenuItemGroup> | ||
| <ContextMenuItemGroup | ||
| aria-labelledby = { microphoneHeaderId } |
There was a problem hiding this comment.
you can name the prop directly ariaLabelledBy, as it does not act as a HTML element attribute on the component, but as a simple prop, and then you can get rid of the aliasing 'aria-labelledby': ariaLabelledBy in the component. Alternatively, you can let it like this and let it propagate through the ...rest props in the component.
By using
menu,groupandmenuitemradiowe have a more clearly and valid structured html.Previously