Skip to content

Support "no signature" signers on local X.509 certificates. #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JonathanLennox
Copy link
Member

As defined in draft-davidben-x509-alg-none.

Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.55%. Comparing base (84c7cba) to head (0249e9e).
Report is 137 commits behind head on master.

Files with missing lines Patch % Lines
...rm/src/main/kotlin/org/jitsi/nlj/dtls/DtlsUtils.kt 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2260      +/-   ##
============================================
- Coverage     45.55%   44.55%   -1.01%     
- Complexity     1972     2117     +145     
============================================
  Files           341      352      +11     
  Lines         18805    19809    +1004     
  Branches       2568     2686     +118     
============================================
+ Hits           8567     8825     +258     
- Misses         9372    10097     +725     
- Partials        866      887      +21     
Files with missing lines Coverage Δ
...ain/kotlin/org/jitsi/nlj/dtls/AlgUnsignedSigner.kt 100.00% <100.00%> (ø)
...m/src/main/kotlin/org/jitsi/nlj/dtls/DtlsConfig.kt 97.29% <100.00%> (-2.71%) ⬇️
...rm/src/main/kotlin/org/jitsi/nlj/dtls/DtlsUtils.kt 56.09% <33.33%> (-2.31%) ⬇️

... and 188 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b4e72...0249e9e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant