-
Notifications
You must be signed in to change notification settings - Fork 596
docs: add diagrams for jj new -A and -B #5635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c6920d
to
04e0c96
Compare
I realize now that I don't mind converting horizontal->vertical or vice versa, but I also don't mind leaving them in an inconsistent state and seeing which will eventually win. |
Can you rewrite the graph without using non-ASCII characters? Unicode drawings might be rendered badly. I don't have any preference over horizontal/vertical. |
I agree with Yuya and think that the graph should be kept vertical to fit into the rest of the documentation as consistency is key. |
I agree with Philip that the graphs should be consistent with our existing graphs to make it easier for users to read them. I don't have much opinion between horizontal vs vertical per se (maybe a slight preference for vertical since it matches |
04e0c96
to
dc81c28
Compare
dc81c28
to
b521357
Compare
I removed unicode and transmuted the diagrams |
last concistency nit from me, use the letters instead of numbers in the graph |
b521357
to
5c76d17
Compare
done, and I switched to |
5c76d17
to
ac452fc
Compare
Hmmm. Anything I need to do to start the CI? Or is it just that the merge queue is long? |
You need to rebase this, it’s from before the CI changes so the mandatory job is never going to happen. |
ac452fc
to
b4627b7
Compare
b4627b7
to
34d9d8b
Compare
Checklist
If applicable:
CHANGELOG.md