Skip to content

cli split: Test how the working copy commit changes across multiple workspaces #5638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

emesterhazy
Copy link
Member

When a commit is split, the second commit produced by the split becomes the working copy commit for all workspaces whose working copy commit was the target of the split.

This commit adds two tests for this behavior:

  1. Split a commit which is the working copy commit for two workspaces.
  2. Split a commit which is the working copy commit for only one of the two workspaces.

These tests check that the working copy commits for the workspaces are updated correctly. Both parallel and non-parallel splits are tested.

…orkspaces

When a commit is split, the second commit produced by the split becomes the
working copy commit for all workspaces whose working copy commit was the target
of the split.

This commit adds two tests for this behavior:

1. Split a commit which is the working copy commit for two workspaces.
2. Split a commit which is the working copy commit for only one of the two
   workspaces.

These tests check that the working copy commits for the workspaces are updated
correctly. Both parallel and non-parallel splits are tested.
@emesterhazy
Copy link
Member Author

These new tests are split out of #5618.

Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll leave approval to a non-googler

@emesterhazy emesterhazy added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 915fe8f Feb 10, 2025
40 checks passed
@emesterhazy emesterhazy deleted the push-ywltvnlntyys branch February 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants