Skip to content

cli: status: replace "is clean" by "has no changes" #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

martinvonz
Copy link
Member

"The working copy has no changes" seems much easier to understand for new users. Thanks to @Wilfred for the suggestion.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@martinvonz
Copy link
Member Author

We also discussed on Discord whether we should update (empty) to (no changes) and rename the empty() revset and the empty template keyword to has_changes() and has_changes for consistency, but those are larger changes with other concerns (e.g. that "changes" in some of those contexts might be misunderstood to be about change ids).

"The working copy has no changes" seems much easier to understand for
new users. Thanks to @Wilfred for the suggestion.
@martinvonz martinvonz enabled auto-merge February 10, 2025 16:02
@martinvonz martinvonz added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 1e25101 Feb 10, 2025
60 checks passed
@martinvonz martinvonz deleted the push-tqtmzopxxzol branch February 10, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants