Skip to content

config-schema: expand options for ui.editor, ui.diff.tool, and ui.pager #5651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

steadmon
Copy link
Member

Fixes #5617

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@steadmon steadmon force-pushed the push-vyvlpokvlzoy branch 3 times, most recently from 51384ba to 5b4e1e2 Compare February 11, 2025 00:41
@steadmon steadmon added this pull request to the merge queue Feb 12, 2025
@steadmon steadmon removed this pull request from the merge queue due to a manual request Feb 12, 2025
…i.pager`

In addition to a single string, the `ui.editor` and `ui.diff.tool` options also
allow arrays of strings. `ui.pager` allows arrays of strings as well as a nested
table describing both the command and the environment.

Update config-schema.json to allow all of these types of values.

Fixes #5617
@steadmon steadmon changed the title config-schema: allow arrays of strings for ui.editor and ui.diff.tool config-schema: expand options for ui.editor, ui.diff.tool, and ui.pager Feb 12, 2025
@steadmon steadmon added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@steadmon steadmon added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@steadmon steadmon added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 69050f3 Feb 12, 2025
41 checks passed
@steadmon steadmon deleted the push-vyvlpokvlzoy branch February 12, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config schema raises an error when using an array for ui.editor
2 participants