Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhaseDiscriminator: handle special 0+0j case here #53

Closed
wants to merge 1 commit into from
Closed

Conversation

jj1bdx
Copy link
Owner

@jj1bdx jj1bdx commented Dec 17, 2023

This is a minimal modification to avoid inputting 0+0j to volk_32fc_s32f_atan2_32f().

Note: I'd rather want to remove this sort of hack altogether if my fix for VOLK 3.1.0 is accepted in the next VOLK release. After that, a possible workaround should be setting the corresponding volk_config entry as: volk_32fc_s32f_atan2_32f polynomial polynomial

@jj1bdx
Copy link
Owner Author

jj1bdx commented Dec 26, 2023

I think we don't need to treat 0+0j at the input of atan2 functions specifically.

@jj1bdx jj1bdx closed this Dec 26, 2023
@jj1bdx jj1bdx deleted the dev-no-nan branch December 26, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant