Skip to content

Conversation

RacheltheEditor
Copy link
Collaborator

No description provided.

@RacheltheEditor RacheltheEditor changed the base branch from master to Rachel-revs3 July 15, 2018 20:44
README.md Outdated
trade. In the United States,
[several kinds of business entities](https://en.wikipedia.org/wiki/Types_of_business_entity#United_States)
may be formed, or [**incorporated**]\(<https://en.wikipedia.org/wiki/Incorporation_(business)>,
may be formed, or [**incorporated**](<https://en.wikipedia.org/wiki/Incorporation_(business)>,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL inside the parentheses includes angle brackets (perhaps because it was copied from somewhere), which is incorrect. It's also missing the closing paren. See here for a correct example:
https://github.com/jlevy/og-equity-compensation/blame/e2.0/README.md#L452

It looks like we can get away with the parens not being percent encoded (%28 or %29) as long as the paren from the URL is followed by the paren from the Markdown syntax.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured out why this was happening: With two closing parens in a Wiki link, Atom Preview shows an extra paren, it does not get absorbed as part of the link. After double checking your example, did not delete the second parens in most recent commit and it looks good in GitHub, even tho the extra parens stands in Preview.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. The extra paren in Preview can be ignored; it's a bug.

This reverts commit 01c80f5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition Content additions restructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants