Sqlserver backed recenthistory #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maldworth
reviewed
Aug 6, 2019
| $"SELECT * \n" + | ||
| $"FROM SELECTION \n" + | ||
| $"WHERE ROW_KEY <= {limit}"; | ||
|
|
There was a problem hiding this comment.
I noticed the original in memory implementation had
.Select(x => x.OrderByDescending(y => y.ActualFireTimeUtc).Take(limitPerJob).Reverse()) within the group by.
I'm not sure if it's necessary or not, but if you wanted to keep it, you could add:
$"ORDER BY {columnName}, ROW_KEY DESC";
and that should perform the same Reverse.
|
👍 Great PR. Hopefully this gets accepted |
|
No news on this pr? :) |
Morphisor
approved these changes
Apr 24, 2020
pigiax
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SQL server recent job history persistence.