Some performance improvements #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2018 18:44
Update css to latest version, taken from https://github.com/missive/emoji-mart/blob/master/css/emoji-mart.css
Move styling from components, now using css file import instead. Revert back PR jm-david#38, tested and debugged, makes emoji picker much more slower so reverting it back.
Updating docs, now using css file. Updated webpack version and added copy-webpack-plugin
This was referenced Dec 3, 2018
|
@jm-david any updates on this? 🙏 |
|
any upadte? |
|
Well, almost 4 months passed, still not merged. Moved to this library https://github.com/kevinfaguiar/cool-emoji-picker |
|
I think I'm going to use your fork, I don't know why this don't get merge. @jm-david |
|
@jm-david Can we merge this PR ? |
|
If someone still need a improved, faster and better version of this package, I'm using this fork and it's way much better and fast, also It's published on npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some changes:
Needs some testing if everything works perfectly for everyone then can be merged and compiled 😃. Performance should be at least %55 better 💯
Now when used with v-show opens instantly 🥇
More fixes for #9 , #29 , #34