Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding platform-uws #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PhearZero
Copy link

@PhearZero PhearZero commented Jul 7, 2023

ℹ️ Overview

Replaces the httpServer with UWS and overrides IoAdapter in @nestjs/platform-socket.io.

🤔 Reasoning

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

🦋 Changeset detected

Latest commit: 8319fac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nest-lab/platform-uws Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jmcdo29
Copy link
Owner

jmcdo29 commented Jul 8, 2023

When you're ready to add this to the deploy pipeline, add a changeset by running pnpm changeset and following the wizard. Initially set the package version to 0.0.0 and choose major for first release

@PhearZero PhearZero marked this pull request as ready for review July 10, 2023 14:29
@jmcdo29
Copy link
Owner

jmcdo29 commented Jul 10, 2023

Ignore the CI failures, it's cause of the branch's origin

Do you have any tests for this package as well? To show it's working as intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants