Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Modifications to Authentication Module #538

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhyman67
Copy link

Modifications to the authentication module so that it can handle the new app notification method (Device approvals).

@bhyman67 bhyman67 changed the title Modifications to Authentication Module Draft: Modifications to Authentication Module Jan 20, 2025
@bhyman67
Copy link
Author

bhyman67 commented Jan 20, 2025

@jmfernandes, is there anything you'd like to see, such as some kind of test result, to validate these changes? If so, what do you think that could look like?

The only challenge I'm facing, though, is that Robinhood is now using SMS to verify me at login rather than the device approval method. I have no idea why that changed... And I've been trying to to configure my settings such that it goes back to using the device approval method. But as of right now, I'm unable to test the code again until I can figure that out... Which is hopefully soon.

But the code changes in this pull request are no different from what I posted in that issues chat for this repo (except for removing comments that I added).

@jmfernandes
Copy link
Owner

You can add screenshots to this PR with the new prompts and login process. Delete your pickle file if using one and show what it would look like for someone to successfully run a simple script. Be careful not to show any personal info or passwords in your screenshots.

@bhyman67
Copy link
Author

Deal! I'll work on this tomorrow. Have a great night!

@bhyman67
Copy link
Author

bhyman67 commented Jan 20, 2025

Hey Josh (@jmfernandes), I'm still struggling with my ability to further test this code... The only way that I've been able to get into my Robinhood account, today, has been though using the passkeys. The SMS and two-factor authentication methods are just not working for my account, both programmatically and manually in the web interface.

I've been in touch with Robinhood support and am in the process of trying to figure this out.

In the meantime, I don't feel comfortable moving forward any further with this until I'm able to test again...

I'm suspecting that things are happening on the Robinhood side that might take a little time to work out...

@bhyman67
Copy link
Author

Just wanted to provide an update on this. The SMS verification is now working again on my account. However, I still haven't been able to get the device approval method to work quite yet... But I am periodically checking! I'd love to continue testing this again as soon as I can. But we'll see how everything pans out...

@NelsonDane
Copy link
Contributor

This Robinhood app approval has worked well for me the past few days using this PR @bhyman67. I would love to get this merged if others from issue #537 feel the same

@bhyman67
Copy link
Author

This Robinhood app approval has worked well for me the past few days using this PR @bhyman67. I would love to get this merged if others from issue #537 feel the same

@NelsonDane:

Great! Yep, I would love to as well.

Would you mind adding screenshots to this PR with the new prompts and login process. Delete your pickle file if using one and show what it would look like for someone to successfully run a simple script using this new authentication module. And just be careful by not showing any personal info or passwords in your screenshots.

I'll see if I can test this again, as well, later tonight (MST).

@doctorcolossus
Copy link

doctorcolossus commented Jan 24, 2025

Working for me as well. A timeout countdown on a single line would be a bit nicer than printing seconds elapsed every five seconds on a new line, especially as a float, but tis a quibble. Thanks for this fix.

@bhyman67
Copy link
Author

Just an FYI, I'm still holding off on this... Robinhood's new 2fa methods are seeming to be a bit finicky... However, we'll see if it starts to stabilize at some point.

#537 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants