Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesign] Access sidebar via gesture #877

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

Komodo5197
Copy link

Allows accessing the sidebar by swiping right when on the leftmost tab of the music screen.

@Chaphasilor
Copy link
Collaborator

The gesture is definitely better than swiping from the edge of the screen, with all of the native gesture navigation now ^^

But in the current planned design for the home screen, the menu is moved to a popup (or maybe a bottom sheet to stay consistent) that is opened by tapping a button in the top right. Here's what I'm referring to:

Home Screen Concept Mockup

The cog (might be replaced with the user's profile picture) would open the menu, and it should be structured similar to Immich's:
image

So I'm not sure how long this change will survive / make sense 😅

@Komodo5197
Copy link
Author

Yeah, I'm aware this might not last that long. But I've found myself instinctively making this gesture an unreasonable amount of times, so I decided I might as well get it in until then.

@Chaphasilor
Copy link
Collaborator

Alright, I guess it won't hurt, and it works just fine in my testing ^^

@Chaphasilor Chaphasilor merged commit 4a79b2d into jmshrv:redesign Sep 14, 2024
4 checks passed
@jmshrv
Copy link
Owner

jmshrv commented Sep 17, 2024

Decided to disable this on iOS since it felt weird with the "bounce" at the end of lists, which Android doesn't have (7da719a).

@jmshrv
Copy link
Owner

jmshrv commented Sep 17, 2024

oh also that change will apply for macOS/Windows/Linux, I actually just enabled it for Android

@Chaphasilor
Copy link
Collaborator

@Komodo5197 aren't you on iOS? I guess you had your reasons for wanting the gesture? 😅

@Komodo5197
Copy link
Author

Actually, my existing phone finally broke a month or two ago, and I ended up with an Android to replace it. It's way larger, because apparently nobody manufactures reasonably sized phones anymore, which is presumably why I kept trying to get the sidebar open with a gesture instead of just using the button.

@Chaphasilor
Copy link
Collaborator

Ah okay. Yeah small phones are very hard to get ahold of. But I'm glad you were able to keep using Finamp! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants