Open
Conversation
…ion when using a JSON string rather than a file location reference
# Conflicts: # .ruby-version # candy_check.gemspec
Owner
|
@phil-allcock Looks almost good to me. As you might see the tests are failing now. I already have a fix-commit here at my machine. Can you please open the PR for me to push commits? |
Author
|
How do I do that @jnbt ? I feel like I'm missing an option somewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #33
In addition to resolving the issue, I have added support for loading key either by directly accessing a file on the system (as in the documentation) or via a pure string through an env var.