feat: Add waveshare 1.75 amoled #482
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughReplaces the LilyGoTDisplayDriver and LilyGo_TDisplayPanel with a new AmoledDisplayDriver and Amoled_DisplayPanel backed by an AmoledHwConfig-driven pin/profile system; legacy per-board pin_config.h for LilyGo T-Display was removed and DefaultUI/Controller now prefer the Amoled driver. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Ctrl as Controller
participant AMD as AmoledDisplayDriver
participant Panel as Amoled_DisplayPanel
participant HW as Hardware (I2C/SPI)
App->>Ctrl: setupPanel()
Ctrl->>AMD: getInstance()
AMD->>AMD: isCompatible()
AMD->>HW: probe profiles (I2C: PCF8563, touch)
HW-->>AMD: probe results
alt compatible
AMD->>AMD: select hwConfig
AMD->>Panel: new Amoled_DisplayPanel(hwConfig)
AMD->>Panel: begin()
Panel->>HW: init display, touch, SD via hwConfig pins
HW-->>Panel: ready
Panel-->>AMD: success
AMD->>Panel: setBrightness(16)
AMD-->>Ctrl: init complete
else incompatible
AMD-->>Ctrl: not compatible
end
Ctrl-->>App: panel status
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/display/drivers/AmoledDisplayDriver.h (1)
1-32: Update the include guard to match this header.The guard name still references
LILYGOTDISPLAYDRIVER_H, which is misleading and risks collisions if any legacy header with the same guard remains. Please rename the guard to something likeAMOLEDDISPLAYDRIVER_Hso it accurately reflects this file.-#ifndef LILYGOTDISPLAYDRIVER_H -#define LILYGOTDISPLAYDRIVER_H +#ifndef AMOLEDDISPLAYDRIVER_H +#define AMOLEDDISPLAYDRIVER_H ... -#endif // LILYGOTDISPLAYDRIVER_H +#endif // AMOLEDDISPLAYDRIVER_H
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
src/display/core/Controller.cpp(2 hunks)src/display/drivers/AmoledDisplay/Amoled_DisplayPanel.cpp(9 hunks)src/display/drivers/AmoledDisplay/Amoled_DisplayPanel.h(4 hunks)src/display/drivers/AmoledDisplay/pin_config.h(1 hunks)src/display/drivers/AmoledDisplayDriver.cpp(1 hunks)src/display/drivers/AmoledDisplayDriver.h(1 hunks)src/display/drivers/LilyGo-T-Display-S3-DS/pin_config.h(0 hunks)src/display/drivers/LilyGoTDisplayDriver.cpp(0 hunks)src/display/drivers/LilyGoTDisplayDriver.h(0 hunks)src/display/ui/default/DefaultUI.cpp(2 hunks)
💤 Files with no reviewable changes (3)
- src/display/drivers/LilyGoTDisplayDriver.cpp
- src/display/drivers/LilyGo-T-Display-S3-DS/pin_config.h
- src/display/drivers/LilyGoTDisplayDriver.h
🧰 Additional context used
🧬 Code graph analysis (4)
src/display/drivers/AmoledDisplayDriver.cpp (1)
src/display/drivers/AmoledDisplayDriver.h (3)
hwConfig(27-27)init(9-10)supportsSDCard(11-19)
src/display/drivers/AmoledDisplay/Amoled_DisplayPanel.cpp (3)
src/display/drivers/AmoledDisplay/Amoled_DisplayPanel.h (3)
Amoled_DisplayPanel(50-112)width(79-79)height(81-81)src/display/drivers/AmoledDisplayDriver.h (1)
hwConfig(27-27)src/display/drivers/AmoledDisplay/CO5300.cpp (2)
setRotation(7-26)setRotation(7-7)
src/display/drivers/AmoledDisplay/Amoled_DisplayPanel.h (3)
src/display/drivers/AmoledDisplay/Amoled_DisplayPanel.cpp (8)
Amoled_DisplayPanel(6-10)Amoled_DisplayPanel(12-29)begin(31-38)begin(31-31)getModel(77-77)getModel(77-77)initDisplay(260-296)initDisplay(260-260)src/display/drivers/common/Display.h (1)
Display(5-18)src/display/drivers/AmoledDisplayDriver.h (1)
hwConfig(27-27)
src/display/drivers/AmoledDisplayDriver.h (3)
src/display/drivers/Driver.h (1)
Driver(5-14)src/display/drivers/AmoledDisplayDriver.cpp (10)
isCompatible(24-36)isCompatible(24-24)init(38-53)init(38-38)supportsSDCard(55-55)supportsSDCard(55-55)installSDCard(57-57)installSDCard(57-57)testHw(59-73)testHw(59-59)src/display/drivers/AmoledDisplay/Amoled_DisplayPanel.cpp (2)
setBrightness(55-73)setBrightness(55-55)
🪛 Clang (14.0.6)
src/display/drivers/AmoledDisplay/pin_config.h
[error] 10-10: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 11-11: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 12-12: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 13-13: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 14-14: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 15-15: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 16-16: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 17-17: unknown type name 'uint16_t'
(clang-diagnostic-error)
[error] 18-18: unknown type name 'uint16_t'
(clang-diagnostic-error)
[error] 19-19: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 20-20: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 21-21: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 22-22: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 23-23: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 24-24: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 25-25: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 26-26: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 27-27: unknown type name 'int8_t'
(clang-diagnostic-error)
[error] 28-28: unknown type name 'int8_t'
(clang-diagnostic-error)
src/display/drivers/AmoledDisplayDriver.h
[error] 4-4: 'display/drivers/AmoledDisplay/Amoled_DisplayPanel.h' file not found
(clang-diagnostic-error)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: deploy
- GitHub Check: test
- GitHub Check: test
|
Summary by CodeRabbit
Refactor
New Features