Skip to content

removal of suspected third-party dependencies of Ghostscript #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

FabJen-JobRad
Copy link

No description provided.

@FabJen-JobRad FabJen-JobRad requested a review from a team July 24, 2025 13:56
@FabJen-JobRad FabJen-JobRad removed the request for review from a team July 24, 2025 14:33
Copy link

@borna-ng borna-ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of best practice suggestions 😁:

  • Write commit messages in imperative case (article)
  • Capitalize and prefix your PR titles and commit messages with the ticket number
  • Be clear on what the PR does, i.e. this pull request does not only remove the dependencies but also Ghostscript itself

With that said, the suggested title would be something like CPT-617 Remove Ghostscript and its dependencies.

@FabJen-JobRad
Copy link
Author

Couple of best practice suggestions 😁:

  • Write commit messages in imperative case (article)
  • Capitalize and prefix your PR titles and commit messages with the ticket number
  • Be clear on what the PR does, i.e. this pull request does not only remove the dependencies but also Ghostscript itself

With that said, the suggested title would be something like CPT-617 Remove Ghostscript and its dependencies.

Appreciated 👌🏼

@FabJen-JobRad FabJen-JobRad deleted the ghostscript_removal branch July 25, 2025 09:21
@FabJen-JobRad
Copy link
Author

closed this PR due to wrong Odoo version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants