Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update displayed date when changing months #16

Conversation

nonninz
Copy link

@nonninz nonninz commented May 15, 2014

Fixes #9

In my opinion, the visualized date ("working date" in code) should always be the same of the actual date ("field date") that would be submitted with the enclosing form.

The prev/next month arrows break this right now updating the visualized date (but not the actually selected date). This pull request fixes this issue.

Please note that I did not update the minified JS

@jockmac22
Copy link
Owner

This is great. I'm haven't merged it yet, because I want to update the minified JS version.

Thanks for the help.

@jockmac22 jockmac22 added the bug label May 15, 2014
@jockmac22 jockmac22 added this to the v0.2b release milestone May 15, 2014
@nonninz
Copy link
Author

nonninz commented May 15, 2014

You are welcome :)

Out of curiosity, how do you compile the minimized version?

@jockmac22
Copy link
Owner

I've been using CodeKit, just add the repo as a project and you can compress the .js file. You could even conceivably add in all of the other dependencies, but I have avoided doing that to make sure that the right parties get their share of attribution.

@nonninz
Copy link
Author

nonninz commented May 15, 2014

Ok thanks :)

@jockmac22
Copy link
Owner

Created a new pull request, in lieu of this pull requrest, to merge this into the v0.2b branch.
Closing this one.

@jockmac22 jockmac22 closed this May 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Going to next or previous month updates visualized date (but not the actual value)
2 participants