Skip to content
This repository was archived by the owner on Jan 24, 2020. It is now read-only.

Fixing subdomain issues #114#117

Open
Nhacsam wants to merge 2 commits intojoeferraro:masterfrom
bamlab:fixing-subdomain-for-webkit
Open

Fixing subdomain issues #114#117
Nhacsam wants to merge 2 commits intojoeferraro:masterfrom
bamlab:fixing-subdomain-for-webkit

Conversation

@Nhacsam
Copy link

@Nhacsam Nhacsam commented Oct 29, 2018

I test if the domain of the cookie match the host url. So, for the url foo.bar.com :

  • bar.com will match
  • barfoo.foo.bar.com will not match
  • foo.bar.com will match

It fix the issue #114

We still have to handle the situation where we have 2 cookies :

const cookie1 = {
  domain: "foo.bar.com",
  name: "session",
  path:"/",
  value: "6de9c6965c1465ed"
};

const cookie2 = {
  domain: "bar.com",
  name: "session",
  path:"/",
  value: "a1784ef82bc"
};

Then the code is non determistic.

It is only for the webkit version

@safaiyeh
Copy link

I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store
We can create issues and PRs there to continue the development of the project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants