Criticalstat #19
Open
Criticalstat #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tool detects code sections in the kernel where IRQs or preemption are disabled for a user-specified amount of time. Requires a kernel built with CONFIG_DEBUG_PREEMPT and CONFIG_PREEMPTIRQ_EVENTS. Signed-off-by: Joel Fernandes <[email protected]>
Changed the type used for stack_id and removed a boundary check made obsolete by the type change
ErickReyesR
force-pushed
the
criticalstat
branch
from
895bfd1 to
ef8cc6f
Compare
When printing out the task name, event.comm.decode() was being called. This was not only redundant, it was causing the script to fail when the task name contained unicode characters
Owner
|
Thanks a lot for this. I am reviewing the commits now. |
joelagnel
reviewed
Jun 18, 2018
| print("%s" % s) | ||
| else: | ||
| print("NO STACK FOUND DUE TO COLLISION") | ||
| kstack = stack_traces.walk(event.stack_id) |
Owner
There was a problem hiding this comment.
This is not right. We need to handle the case where a stack collision occurred. I will fix it up.
Author
There was a problem hiding this comment.
I thought that condition was handled at line 303
joelagnel
force-pushed
the
criticalstat
branch
2 times, most recently
from
8afa064 to
5e0911b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joel,
Fixed the easy ones first. Still figuring out the rest.