WIP: Transforms #70
Open
WIP: Transforms #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified setup.py accordingly. Also made coherent the location of the sglite library location with that of transforms.
name and path changes to get xf_numpy to import
Signed-off-by: Oscar Villellas <[email protected]>
Also added a workaround to the jit dispatcher not supporting ‘signature’
includes some clean up of numba functions.
For the default beam vector and the default eta vector an identity matrix should return. This is kind of assumed in other parts of the code.
Fixed api version so it generates the exceptions as the other versions do. Made the error messages a bit more coherent.
also fixed type with atol (1e+10 was meant to be 1e-10)
caught a bug in array version in numba.
added 2 commits
October 30, 2018 11:21
So that it serves as documentation for the submodule testing as well as guidelines for test writers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On-going refactoring to have a more consistent transforms codebase (and with more tests).
Scaffolding done, including a system to ensure the API is consistent and the documentation is shared along the different implementations. API definition metadata describes the API call and documents it. A decorator system makes it easy to declare a function as an implementation of the API. The decorator checks that the function fits the API definition and adds the definition comment to the decorated function. The definitions also support the definition of PRE and POST conditions for parameters and result that must be true. These conditions can be run optionally by setting the HEXRD_XF_CHECK environment variable.
Full first implementation using numpy.
Partial implementation based on what was available using the C extension module.
Testing scaffolding done, with a test file for each function. A system that allows to run the very same tests on different equivalent implementations with little effort.