fix(HTMLRenderer): re-implementing processors and their options #403
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have done 3 changes: 1) I have added back the processors and processor_options attributes into the HTMLRenderer class, so that JSONForHTMLRenderer class can have access to them, when created by HTMLRenderer. 2) In the process of doing 1), I have renamed attribute HTMLRenderer.preprocessors to HTMLRenderer.processors, as it seems more logical. Because of this magic.py had to be updated. 3) I have added these 2 attributes inputs into the Profiler.output_html, as without them one test was not passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done 3 changes:
I have added back the
processorsandprocessor_optionsattributes into theHTMLRendererclass, so thatJSONForHTMLRendererclass can have access to them, when created byHTMLRenderer.In the process of doing 1), I have renamed attribute
HTMLRenderer.preprocessorstoHTMLRenderer.processors, as it seems more logical. Because of thismagic.pyhad to be updated.I have added these 2 attributes into the
Profiler.output_html, as without them one test was not passing.I have also wanted to update the online docs, but I did not find a way how to change the
docs/reference.md.This PR addresses the issue #401