Fix pattern cast line numbers (#5228)

joernio · Jan 14, 2025 · 48d26b5 · 48d26b5
1 parent ee19e27
commit 48d26b5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.../scala/io/joern/javasrc2cpg/astcreation/expressions/AstForPatternExpressionsCreator.scala b/.../scala/io/joern/javasrc2cpg/astcreation/expressions/AstForPatternExpressionsCreator.scala
@@ -190,7 +190,9 @@ trait AstForPatternExpressionsCreator { this: AstCreator =>
         newOperatorCallNode(
           Operators.cast,
           s"(${castType.code}) ${initializerAst.rootCodeOrEmpty}",
-          Option(patternType)
+          Option(patternType),
+          line(patternExpr),
+          column(patternExpr)
         )
       callAst(castNode, Ast(castType) :: initializerAst :: Nil)
     }

diff --git a/...frontends/javasrc2cpg/src/test/scala/io/joern/javasrc2cpg/querying/PatternExprTests.scala b/...frontends/javasrc2cpg/src/test/scala/io/joern/javasrc2cpg/querying/PatternExprTests.scala
@@ -2173,6 +2173,8 @@ class PatternExprTests extends JavaSrcCode2CpgFixture {
               oCast.name shouldBe Operators.cast
               oCast.code shouldBe "(Box) o"
               oCast.typeFullName shouldBe "box.Box"
+              oCast.lineNumber shouldBe Some(9)
+              oCast.columnNumber shouldBe Some(12)
 
               inside(oCast.argument.l) { case List(boxType: TypeRef, oIdentifier: Identifier) =>
                 boxType.typeFullName shouldBe "box.Box"