Skip to content

Fix/improve install from source docs#231

Merged
joeyates merged 4 commits intojoeyates:mainfrom
axelsimon:docs-install-from-source
Apr 2, 2025
Merged

Fix/improve install from source docs#231
joeyates merged 4 commits intojoeyates:mainfrom
axelsimon:docs-install-from-source

Conversation

@axelsimon
Copy link
Contributor

Quick doc + README fixes.

File was messed up: fix and improve.
Fix broken link to /doc/installation/source.md
Copy link
Owner

@joeyates joeyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've added a couple of notes for quick fixes

congratulations, you have succesfully built imap-backup.

Check that it runs
You ca now run the following to see the built-in help:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now fixed.

```
imap-backup 14.4.4
```
congratulations, you have succesfully built imap-backup.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a blank line after code blocks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!


<details>
<summary>From Source Code</summary>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, this doesn't change the rendered document. Is the newline needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When playing with the Github preview it seemed necessary to get [here](/docs/installation/source.md) to render as a link. Currently, that render is not working. And, looking at it some more, it's also needed for the * [Rubygem] and Homebrew shield to render properly, both are also currently not rendering right. I'll fix those too.

@axelsimon axelsimon requested a review from joeyates March 19, 2025 16:05
@joeyates joeyates merged commit 020b40d into joeyates:main Apr 2, 2025
@joeyates
Copy link
Owner

joeyates commented Apr 2, 2025

Thanks @axelsimon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants