-
Notifications
You must be signed in to change notification settings - Fork 31
Apply rustfmt
#261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply rustfmt
#261
Conversation
|
Btw, we still have more than a day, until 18. Oct., 23:59 Pacific time, to use up ~$500 of CCW creds. :) |
|
Hi! I just created a similar PR an hour ago :D #260 |
|
Awesome. I think the highest priority should be DWA compression. That one doesn't have an open PR yet, or did not see it? :) |
Ok, I cherry-picked the workflow commit from your PR and amended my commit to contain the So theoretically my commit should have everything yours had plus the It would be good to merge either one asap so I can ask Claude to re-base the three branches, DWA, channel subsampling and deep data on this. |
|
Sorry I didn't have the time to review it yet. But I'm certain we can still do it. I hope I can do some of it tomorrow or on the weekend. |
|
Thanks for your patience! I know that you might not have access to Claude anymore. I still want to attempt as much as possible of this though. So, I tried running this formatting, but it does not go completely as hoped. Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `reorder_impl_items = true`, unstable features are only available in nightly channel.
Warning: can't set `unstable_features = true`, unstable features are only available in nightly channel.Which is also the reason that the pipeline fails. It seems we would either have to switch the whole repo toolchain to nightly, or instead remove the unstable formatting options, or always use |
|
I took the liberty to commit into your branch, I hope that's okay? :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the formatter locally to ensure the correctness. Thanks!
This applies
cargo fmtto currentmaster,rustfmt.tomlused:unstable_features = true-- Enables unstable rustfmt features. Required for options likeimports_granularityandreorder_impl_itemsthat aren't yet stable.format_code_in_doc_comments = true-- Formats Rust code blocks inside documentation comments (e.g., in///and//!comments). Code examples in docs will be formatted consistently with the rest of your code.imports_granularity = "Crate"-- Merges imports from the same crate into a single use statement. For example:becomes:
reorder_impl_items = true-- Reorders items within impl blocks alphabetically by item type (types, consts, macros, then methods). Helps maintain consistent ordering.use_field_init_shorthand = true-- Uses field init shorthand when field name matches the variable name:wrap_comments = true-- Wraps comments atmax_width(100 chars by default), breaking long comment lines into multiple lines for better readability.I would try to re-base the work of Claude on this commit, if you're ok with the above.