Cherrypick claude review #268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesvollmer
commented
Jan 29, 2026
|
|
||
| bench.iter(|| { | ||
| let image = read_file_from_memory_as::<f16>(file.as_slice(), parallel); | ||
| let image = read_file_from_memory_as::<T>(file.as_slice(), parallel); |
Owner
Author
There was a problem hiding this comment.
Epic catch! The benchmarks for conversion were not correct 🫢 This fixes it, and different measurements are the result!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicked from #256 this PR mainly improves readability of the code by using standard patterns where non-standard patterns were used before. There should be no breaking changes in this PR.
Observable for downstream users: Some error messages have been improved.
Some minor bugs in tests and benchmarks are fixed.