Skip to content

feat: add times around earth stat #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Conversation

edbourque0
Copy link
Contributor

No description provided.

@johanohly
Copy link
Owner

Thank you for the pull request and sorry for the delay, I was away from my laptop for the weekend.

I generally like the idea of having this stat, but I think the execution needs some rethinking.
CleanShot 2025-02-25 at 11 58 42@2x
This doesn't really look good. What about just having a globe emoji?
CleanShot 2025-02-25 at 12 00 50@2x

@edbourque0
Copy link
Contributor Author

Thank you for the pull request and sorry for the delay, I was away from my laptop for the weekend.

I generally like the idea of having this stat, but I think the execution needs some rethinking. CleanShot 2025-02-25 at 11 58 42@2x This doesn't really look good. What about just having a globe emoji? CleanShot 2025-02-25 at 12 00 50@2x

Great idea! I also thought that the text was a bit long.

@johanohly johanohly changed the title Add times around earth stat feat: add times around earth stat Mar 5, 2025
Copy link

sonarqubecloud bot commented Mar 5, 2025

@johanohly johanohly merged commit fb4bf4f into johanohly:main Mar 5, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants