Skip to content

feat: update the list of airlines #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

avee87
Copy link

@avee87 avee87 commented Mar 6, 2025

Current list is missing come airlines - particularly, some of those that went out of business. See some examples in #158
I found this bigger list here which should include them all: https://en.wikipedia.org/wiki/List_of_airline_codes

@github-actions github-actions bot added the Web label Mar 6, 2025
@avee87 avee87 changed the title Updated the list of airlines feat: Update the list of airlines Mar 6, 2025
@avee87 avee87 changed the title feat: Update the list of airlines feat: update the list of airlines Mar 6, 2025
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
16.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@johanohly
Copy link
Owner

Thank you for opening this pull request! I think this is a good idea, but I ran a simple script to check if any ICAO codes are in the old list, but missing in the new, and found almost 500 out of the total 2000 missing from the new list.

This would be a pretty big breaking change, and I don't really know how we could justify it really. I also can't think of a way to migrate outdated codes to the new ones, as we don't know the mapping.

@avee87
Copy link
Author

avee87 commented Mar 6, 2025

This is interesting... I wonder if the differences are actually meaningful - i.e., if those missing airlines actually carried any passengers. I wonder if we could merge these lists. Do you know where the current one came from originally?

@johanohly
Copy link
Owner

Yes, it is from FlightRadar24 (https://www.flightradar24.com/_json/airlines.php). One solution could be to just transfer all the missing airlines to the new one.

@avee87
Copy link
Author

avee87 commented Mar 10, 2025

Looks like the proper solution will have to be more complicated. ICAO codes seem to be reused: for instance, AirBerlin had ICAO code BER but now it's used by Fly Air41. Unless we implement some system for properly tracking periods when each airline is/was active, there will be errors.

@conchyliculture
Copy link

the PR also adds airline objects with the ICAO code having a null value, which the AirTrail code isn't expecting (and crashes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants