Skip to content

feat: improve airport bubble sizes #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

johanohly
Copy link
Owner

@johanohly johanohly commented Apr 29, 2025

CleanShot 2025-04-29 at 11 06 02@2x
CleanShot 2025-04-29 at 11 07 09@2x

Copy link

@johanohly johanohly requested a review from Copilot April 29, 2025 09:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the airport bubble size calculation in the data preparation logic by adjusting the scaling factors for frequency.

  • Updated MIN_FREQUENCY from 0.5 to 1
  • Replaced maximum-based normalization with a min-max normalization approach for computing frequency
Files not reviewed (1)
  • src/lib/components/map/AirportsArcsLayer.svelte: Language not supported
Comments suppressed due to low confidence (1)

src/lib/utils/data/data.ts:150

  • [nitpick] Consider renaming 'normalised' to 'normalizedFrequency' (or 'normalized') to maintain consistency with prior naming conventions.
const normalised = (combined - rawMin) / span;

@johanohly johanohly merged commit 374a5be into main Apr 29, 2025
12 checks passed
@johanohly johanohly deleted the feat/airport-bubbles-size branch April 29, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant