Make auto show/hide functionality opt-in #623
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one possible approach for #620. It's a bit rough but seems to do the trick - hopefully I didn't miss anything.
When a panel has been pinned but is no longer present, it falls back to the overview panel.
To address the intended auto show/hide behavior, it introduces a new constant QM_AUTO_SHOW. When this constant is truthy, QM will automatically open if the php errors panel or timing panel is present (from my limited testing it seems like the logs panel is always present even if there are no logs to show - please let me know if this is incorrect).
I opted for the constant as it seemed like the simplest approach but wasn't sure if it was the ideal one. An alternative I considered was adding a section to the settings panel and storing the users preference in localstorage.
Let me know what you think, or if this is even something you are interested in changing.