Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto show/hide functionality opt-in #623

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ssnepenthe
Copy link
Contributor

This is one possible approach for #620. It's a bit rough but seems to do the trick - hopefully I didn't miss anything.

When a panel has been pinned but is no longer present, it falls back to the overview panel.

To address the intended auto show/hide behavior, it introduces a new constant QM_AUTO_SHOW. When this constant is truthy, QM will automatically open if the php errors panel or timing panel is present (from my limited testing it seems like the logs panel is always present even if there are no logs to show - please let me know if this is incorrect).

I opted for the constant as it seemed like the simplest approach but wasn't sure if it was the ideal one. An alternative I considered was adding a section to the settings panel and storing the users preference in localstorage.

Let me know what you think, or if this is even something you are interested in changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant