Skip to content

features/multiple styles in same text #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Fernando-hub527
Copy link
Collaborator

Description
This pr allows you to merge different styles in the same text, to do this merge it is necessary that when creating the component, a list of subTexts is sent, each subText with its own style.

Related Issue
#189

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 57.51634% with 65 lines in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (4207ca1) to head (8471e92).

Files with missing lines Patch % Lines
internal/providers/gofpdf/text.go 51.14% 42 Missing and 1 partial ⚠️
pkg/props/subtext.go 33.34% 20 Missing ⚠️
internal/providers/gofpdf/provider.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   87.98%   87.29%   -0.68%     
==========================================
  Files          61       62       +1     
  Lines        2336     2407      +71     
==========================================
+ Hits         2055     2101      +46     
- Misses        246      270      +24     
- Partials       35       36       +1     
Flag Coverage Δ
unittests 87.29% <57.52%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joeyave
Copy link

joeyave commented Apr 21, 2025

Any update on when it could be merged?

@agus24
Copy link

agus24 commented Jul 7, 2025

i think this will fix this issue #525

any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants