deploy to lambda #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put and improved steps
Co-authored-by: Copilot <[email protected]>
Feature/s3+local2
fix: copy static files to lambda artifacts directory
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AWS Lambda deployment workflow to use the official AWS Lambda deploy action instead of a third-party action, and updates the Docker configuration to use a container registry image.
- Replaces third-party
appleboy/lambda-actionwith officialaws-actions/aws-lambda-deploy@v1 - Adds manual workflow dispatch capability with optional function name override
- Updates Docker Compose to use GitHub Container Registry image
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker/docker-compose.yml | Updates image reference to use GitHub Container Registry |
| .github/workflows/deploy-lambda.yml | Complete rewrite of Lambda deployment using official AWS actions with enhanced configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| echo "LAMBDA_FUNCTION_NAME variable is required when no manual input is provided" >&2 | ||
| exit 1 | ||
| fi | ||
| echo "Using function name from secret" |
There was a problem hiding this comment.
The error message is misleading. The function name is retrieved from vars.LAMBDA_FUNCTION_NAME which is a repository variable, not a secret. The message should say 'Using function name from repository variable'.
Suggested change
| echo "Using function name from secret" | |
| echo "Using function name from repository variable" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.