Bug in the dark mode functionality #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made are on the isFakeDark mode feature. Initially when the application runs at first,there is a conflict between the default darkmode settings (which may occur on diffrent users machines) and the state setting which by default is set to false. To solve this, I have included code which checks if there is any user predefined theme on the local storage or any system defined theme at component mount. On the useEffect, the "fake-dark-mode" class is toggled respectively while updating the localstorage theme as per the isFakeDark state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made are on the isFakeDark mode feature.
Initially when the application runs at first,there is a conflict between the default darkmode settings (which may occur on diffrent users machines) and the state setting which by default is set to false.
To solve this, I have included code which checks if there is any user predefined theme on the local storage or any system defined theme at component mount.
On the useEffect, the "fake-dark-mode" class is toggled respectively while updating the localstorage theme as per the isFakeDark state.