Skip to content

Fix ci #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Fix ci #439

merged 9 commits into from
Jan 8, 2025

Conversation

davide-f
Copy link
Contributor

@davide-f davide-f commented Jan 4, 2025

This PR aims to fix (at least parts of) the CI
Linked to #438

@davide-f
Copy link
Contributor Author

davide-f commented Jan 4, 2025

This PR fixes an issue in the docs.
I'm experiencing a segmentation fault in the coverage test when launching:
coverage run -m pytest --doctest-modules chaospy/ tests/ README.rst

chaospy/external/openturns_.py Fatal Python error: Segmentation fault

At least locally, I'm experiencing such error, while the docs seems fine also by testing them locally.
The difference with respect to documentation is that "chaospy.OpenTURNSDist(dependent_distribution)" may be working. Not sure if intended

@jonathf
Copy link
Owner

jonathf commented Jan 5, 2025

@davide-f, thanks for the contribution. I have no issue merging this.

Openturns is broken now on my end as well. It wasn't before the holidays I think.

@regislebrun, do you know anything about this error above?

@jonathf
Copy link
Owner

jonathf commented Jan 5, 2025

Testing out multiple versions of python now and I can confirm that it segfaults on versions 3.9, 3.10 and 3.11. However I have no issues on 3.12 which I usually use.

@davide-f
Copy link
Contributor Author

davide-f commented Jan 5, 2025

Many thanks @jonathf :)

@davide-f davide-f closed this Jan 5, 2025
@davide-f davide-f reopened this Jan 5, 2025
@davide-f
Copy link
Contributor Author

davide-f commented Jan 5, 2025

My bad... misclicked...

@davide-f
Copy link
Contributor Author

davide-f commented Jan 7, 2025

Testing out multiple versions of python now and I can confirm that it segfaults on versions 3.9, 3.10 and 3.11. However I have no issues on 3.12 which I usually use.

I've tested with 3.12 and it still fails for me but the model succeeds when setting openturns=1.23

@jonathf
Copy link
Owner

jonathf commented Jan 8, 2025

Great. Pinning the requirement is a good solution for the time being. I'll remember to revisit the topic later if there is any changes.

Do you mind fixing the formatting before we merge?

@davide-f
Copy link
Contributor Author

davide-f commented Jan 8, 2025

No problem, I'll do today. Many thanks!
Regarding the conda feedstock, instead what do you think?

@jonathf
Copy link
Owner

jonathf commented Jan 8, 2025

Unsure. I don't think there is anything to do beyond what you have already done with conda-forge/chaospy-feedstock#56.

@davide-f
Copy link
Contributor Author

davide-f commented Jan 8, 2025

Unsure. I don't think there is anything to do beyond what you have already done with conda-forge/chaospy-feedstock#56.

Many thanks :) Linter is now fixed.
As a comment, before releasing a new pip version, it would be great to fix the conda-forge, because after that the autobot in conda-forge would automatically take care of merging consequent versions unless problems arise.
Otherwise more manual interventions are needed.

To plan the developments in pypsa-earth, regarding conda-forge/chaospy-feedstock#56, when do you expect that PR could be addressed?

@jonathf
Copy link
Owner

jonathf commented Jan 8, 2025

I can wait with release, sure.

I am not associated with conda, so I wouldn't know how long that would take. If you are not getting response from jschueller, perhaps you could try pinging someone else there with merge rights, like e.g. bgruening?

@davide-f
Copy link
Contributor Author

davide-f commented Jan 8, 2025

I can wait with release, sure.

I am not associated with conda, so I wouldn't know how long that would take. If you are not getting response from jschueller, perhaps you could try pinging someone else there with merge rights, like e.g. bgruening?

Many thanks, I'll ping him too, just in case.
I see the CI is broken because of codecov limits; let me know if you wish something to be changed. Many thanks!

@jonathf jonathf merged commit 897282f into jonathf:master Jan 8, 2025
1 check failed
@jonathf
Copy link
Owner

jonathf commented Jan 8, 2025

Don't worry about that. I'll handle that seperatly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants