Skip to content

Origin Location Parsing Improvement #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025

Conversation

jamessimone
Copy link
Collaborator

Slight tweak to origin location stack trace parsing in Apex to improve how origin location is displayed

Noticed while we were cross-checking the following issue: jamessimone/apex-rollup#683 (comment)

@jamessimone jamessimone requested a review from jongpie as a code owner May 27, 2025 20:26
@jamessimone jamessimone had a problem deploying to Advanced Scratch Org May 27, 2025 20:35 — with GitHub Actions Failure
@jamessimone jamessimone temporarily deployed to Base Scratch Org May 27, 2025 20:35 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Event Monitoring Scratch Org May 27, 2025 20:35 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to OmniStudio Scratch Org May 27, 2025 20:48 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Platform Cache Scratch Org May 27, 2025 20:50 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Advanced Scratch Org May 28, 2025 12:50 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Experience Cloud Scratch Org May 28, 2025 13:11 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Advanced Scratch Org May 30, 2025 16:26 — with GitHub Actions Inactive
@jamessimone jamessimone had a problem deploying to Event Monitoring Scratch Org May 30, 2025 16:26 — with GitHub Actions Failure
@jamessimone jamessimone temporarily deployed to Experience Cloud Scratch Org May 30, 2025 16:47 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Advanced Scratch Org May 30, 2025 18:08 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Event Monitoring Scratch Org May 30, 2025 18:08 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Platform Cache Scratch Org May 30, 2025 18:21 — with GitHub Actions Inactive
@jamessimone jamessimone had a problem deploying to Experience Cloud Scratch Org May 30, 2025 18:27 — with GitHub Actions Failure
@jongpie jongpie added Type: Enhancement New feature or request Logging Source: Apex Items related to using Logger within Apex Layer: Logger Engine Items related to the core logging engine labels May 30, 2025
@jamessimone jamessimone temporarily deployed to Base Scratch Org May 30, 2025 20:00 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Experience Cloud Scratch Org May 30, 2025 20:00 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to OmniStudio Scratch Org May 30, 2025 20:14 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Base Scratch Org May 30, 2025 20:32 — with GitHub Actions Inactive
@jamessimone jamessimone temporarily deployed to Base Scratch Org May 30, 2025 20:45 — with GitHub Actions Inactive
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (0642147) to head (70e6807).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   86.19%   91.49%   +5.30%     
==========================================
  Files          17       58      +41     
  Lines        1318     6316    +4998     
  Branches      199      199              
==========================================
+ Hits         1136     5779    +4643     
- Misses        162      517     +355     
  Partials       20       20              
Flag Coverage Δ
Apex 92.89% <100.00%> (?)
LWC 86.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner

@jongpie jongpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamessimone this looks great, it's ready to merge! Let me know if you want me to handle merging + release notes, or if you'd like to do it.

@jamessimone jamessimone merged commit 4fbfaa8 into main Jun 2, 2025
1 check passed
@jamessimone jamessimone deleted the external-entry-point-stacktrace-parsing branch June 2, 2025 18:54
@jamessimone
Copy link
Collaborator Author

I'll do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Logger Engine Items related to the core logging engine Logging Source: Apex Items related to using Logger within Apex Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants