Chore: Bump cheerio from 0.22.0 to 1.0.0-rc.10 #114
Closed
+13,904
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible for this PR to get merged to resolve this issue? |
|
I wonder why the tests didn't run. I would need to verify that first. |
Merge from forked repositories does not have permission for action |
|
Hi! I tried to fix them in another PR: #115 |
|
Tests are failing. |
|
All tests were successful when I launched npm run test. |
|
@pleymor this is not your pr but I did leave feedback on yours too. Can you address that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#111 There was an nth-check security issue in cheerio > css-select > nth-check dependency, so cheerio version was updated