Strip 'px' from numeric values when inlining table,td,th height and width attributes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkemp
reviewed
Jan 2, 2020
lib/setTableAttrs.js
Outdated
| $el.attr(styleToAttrMap[style], styleVal); | ||
| $el.attr( | ||
| styleToAttrMap[style], | ||
| (attributesToRemovePxFrom.indexOf(style) > -1) |
There was a problem hiding this comment.
This is a style issue but I think there is a better way to handle this. Maybe create a variable for it? I don't like including the ternary assignment here or splitting it into multiple lines like that.
There was a problem hiding this comment.
I'm not married to it. You prefer if statements to ternaries?
There was a problem hiding this comment.
Updated in master :)
jonkemp
reviewed
Jan 2, 2020
| @@ -5,7 +5,7 @@ | |||
| background-color: red; | |||
| float: left; | |||
| width: 100%; | |||
| height: 500px; | |||
| height: 500PX; | |||
There was a problem hiding this comment.
The regex to replace px values is case insensitive. This tests that PX which is valid CSS will also be removed.
|
Lint task is failing so the build is failing now. 😄 |
Fixed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct format for inlining these values is width="200" vs width="200px". This PR handles case insensitive stripping of 'px' from the end of the attribute value when the key is height or width.