Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize distro support and remove deprecated stdlib functions #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

colonelpanik
Copy link

@colonelpanik colonelpanik commented Dec 24, 2021

This removes the deprecated stdlib validate_ functions and adds Centos/RHEL/Rocky 8 support. Lightly tested on Ubuntu 20 as well and worked as-is with puppet 6 prior to this change so this should work there as well.

As the spec tests were relatively normal, I also took the chance to convert this to puppet pdk style module for easier unit testing. I can split these two changes off into separate PRs if you prefer.

@arcadius
Copy link

I am seeing the deprecations below @jonmosco
It would be great if we could have a new release with this pull request please.

Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 28]:["/tmp/mnc/puppet/manifests/site.pp", 0] (location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function,
with Stdlib::Compat::Array. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 30]:["/tmp/mnc/puppet/manifests/site.pp", 0]
(location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation') Warning: This method is deprecated, please use the stdlib validate_legacy function, with Pattern[]. There is further documentation for validate_legacy function in the README. at ["/etc/puppet/code/modules/logwatch/manifests/init.pp", 32]:["/tmp/mnc/puppet/manifests/site.pp", 0] (location: /etc/puppet/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in deprecation')
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants