A bunch of minor edits. #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I was exploring the code, there were somethings that seems could be cleanup up slightly. Happy to drop all or revert some.
yschimke
commented
Dec 31, 2024
| @@ -66,9 +67,11 @@ kotlin { | |||
| } | |||
|
|
|||
| androidMain.dependencies { | |||
| implementation(libs.ktor.client.android) | |||
| implementation(libs.ktor.client.okhttp) | |||
There was a problem hiding this comment.
better than Android HttpClient. Http/2.
Not used on JVM, since HttpClient is modern.
yschimke
commented
Dec 31, 2024
| expectSuccess = true | ||
|
|
||
| defaultRequest { | ||
| url("https://api.citybik.es/") |
There was a problem hiding this comment.
for easier mock testing, but already a param so can revert.
yschimke
commented
Dec 31, 2024
| // workaround for https://youtrack.jetbrains.com/issue/CMP-5959/Invalid-redirect-in-window-core#focus=Comments-27-10365630.0-0 | ||
| implementation("androidx.window:window-core:1.3.0") | ||
| implementation(libs.slf4j.android) |
There was a problem hiding this comment.
enable logging output
yschimke
commented
Dec 31, 2024
| androidGradlePlugin = "8.7.3" | ||
| androidxActivity = "1.9.3" |
joreilly
reviewed
Dec 31, 2024
|
|
||
| val countriesViewModel: CountriesViewModelShared | ||
| val networksViewModel: NetworksViewModelShared | ||
| val stationsViewModel: StationsViewModelShared |
There was a problem hiding this comment.
these are needed right now for iOS client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was exploring the code, there were somethings that seems could be slightly cleaned up.
Happy to drop all or revert some.