Skip to content

Conversation

kaisermann
Copy link
Contributor

@kaisermann kaisermann commented Mar 23, 2025

Based on this discussion and my own confusion around these Sonarr actions when mediaType=shows, I just added a show after the unmonitor verb so it's clearer what the code is actually doing.

This also aligns the other options with the existing Unmonitor show and keep files one, which already has "show" after "unmonitor"

@kaisermann kaisermann force-pushed the clearer-sonarr-action-for-shows branch from 93bb36d to 2156b76 Compare March 23, 2025 09:37
@benscobie benscobie self-assigned this Mar 23, 2025
{
id: 2,
name: 'Unmonitor and delete existing seasons / episodes',
name: 'Unmonitor show and delete existing seasons / episodes',
Copy link
Collaborator

@benscobie benscobie Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth being more verbose about what will happen. It's not obvious what happens to the monitor status of seasons & episodes. From my interpretation:
Unmonitors show
Keeps seasons monitored
Unmonitors and deletes existing episodes

{
id: 1,
name: 'Unmonitor and delete all seasons / episodes',
name: 'Unmonitor show and delete all seasons / episodes',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this but I need to validate what happens to the episode monitor status. It doesn't look like we explicitly unmonitor each episode, but I am wondering if unmonitoring the season somehow causes the episodes to be unmonitored:

Unmonitors show
Unmonitors seasons
Unmonitors(?) and deletes existing episodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants