-
-
Notifications
You must be signed in to change notification settings - Fork 52
Feat : partial jellyfin & qBittorrent & docker for local developpement #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It you want me to do some adjustements you can ask me here :) |
@JolanLar Firstly thank you for the PR, there is a lot to digest here! I'll start with the qBitorrent addition for the moment. I had a look at implementing torrent deletion a little while ago and it is quite a can of worms. There are a lot of scenarios to deal with which is why I didn't start 😆 I'm not sure this is going to work for Sonarr the way it currently is. Say I have a rule that is set to This will also miss torrents in the scenario where an episode was downloaded as a single torrent and then replaced with a season pack later. Lastly, if you're cross seeding the torrent, this will leave that torrent in an error state as the files have been removed. If you cross seed using hard links then you have a different problem as the space won't have been freed. Ref the Docker addition, I think devcontainers might be better suited here. Windows suffers bad IO performance when mounting a local volume in WSL2. The recommendation there is to clone inside the container, devcontainers in VSCode makes this easy with We typically create a PR per feature/bug fix, and certainly in this case with multiple chunky features. Looking at your commit log you should be able to cherry pick them out easily enough. |
Thanks for the feedback. I’ve only used the For the upgraded files, I think the request made to I'm not familiar with cross-seeding, but I think the easiest way would be to tag all the torrents with the Sonarr/Radarr tag, so they’d appear in the /history request and be deleted as well. Otherwise, I can check for other torrents sharing the same files and delete them. For the Docker addition, I used the same logic as Overseerr, but the VSCode devcontainers look interesting. I’ll look into that. |
@JolanLar Plex is still required to setup jellyfin ? |
Actually, yes. Sorry, but I don’t think I’m going to implement Jellyfin-only support. This version meets all my needs, I think your best option is to use Janitorr. |
I was wondering if this PR will be merged in the near future? Any chance to get rid of the plex integration and requirements? |
Jellyfin:
qBittorrent:
Docker: