🐛 Fix boolean comparator bug #1857
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be what was causing null values still causing matches.
Description
Boolean logic issue where
|| null
is not parsed as "is not undefined or null" but "is not undefined" as|| null
always evaluates to "or is false" which is always false.Related issue
Potentially fixes issues like #1406.
Checklist
Additional context
Thank you very much for spending time on this excellent piece of software. You've saved me so much time 🙏