Clarify why “Save in keychain” MUST be disabled #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some language in the README.
pinentry-touchid
, how, and why, allowing people to make a more informed choice, instead of just thinking, “why would I disable saving to the keychain?, that's what I want”.pinentry-mac
, but bypinentry-touchid
; more people will adhere to this “recommendation” if they realise it's merely a formality, and they're not actually giving up saving the entry to the Keychain.With these three changes, I reckon most people will at least manually disable the checkbox every time they create a new entry for a new keypair, which may still result in some people forgetting when they renew their keypairs some years later, but it's better than the status quo.
Also, most people might still
defaults write
to make that the default, as even if they switch back topinentry-mac
, having to constantly enable that checkbox is better than causing a subtle breakage if they stick withpinentry-touchid
that causes them to be unable to decrypt files and thinking their key is broken or something.Honestly, this is just another reason to switch away from
pinentry-mac
at this point. It's a dead project, it creates work for the user — having to ensure the presence and right target of a symlink, having to remember this Save in keychain business, etc — and it kinda locks us in to its decisions.At least a better fix for this particular issue might simply be to save the keypair without the comment, as the ID is still in the title, but that's a bit of a loss, so even better would be to search both with and without the comment before creating a new entry.