MSSQL: fix the way GUIDs are shown #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 byte little endian GUID
Contributor
Author
|
@jorgerojas26 @ccoVeille guys can you have a look? |
ccoVeille
reviewed
Oct 6, 2025
Comment on lines
+339
to
+340
| // if guid, errParse := uuid.FromBytes(*rawBytes); errParse == nil { | ||
| // row = append(row, guid.String()) // Use standard GUID format if valid |
Contributor
There was a problem hiding this comment.
This looks like left behind code
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently guids are shown like:
39887ea6-d811-c64c-8611-eefb36ad631e
but should be
a67e8839-11d8-4cc6-8611-eefb36ad631e
note how the order is flipped in eg. c64c and 4cc6
This is how it looks in current lazysql version:
This PR fixes it:
Now it's same as the one shown in other MS SQL editors, eg. Visual Studio Code below:
