fix: function clone not throwing an error in case of an unsupported…

… type like a function
josdejong · Oct 25, 2023 · 0222ff7 · 0222ff7
1 parent 8f8e506
commit 0222ff7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/utils/object.js b/src/utils/object.js
@@ -1,4 +1,4 @@
-import { isBigNumber } from './is.js'
+import { isBigNumber, isObject } from './is.js'
 
 /**
  * Clone an object
@@ -34,10 +34,13 @@ export function clone (x) {
 
   if (x instanceof Date) return new Date(x.valueOf())
   if (isBigNumber(x)) return x // bignumbers are immutable
-  if (x instanceof RegExp) throw new TypeError('Cannot clone ' + x) // TODO: clone a RegExp
 
   // object
-  return mapObject(x, clone)
+  if (isObject(x)) {
+    return mapObject(x, clone)
+  }
+
+  throw new TypeError(`Cannot clone: unknown type of value (value: ${x})`)
 }
 
 /**

diff --git a/test/unit-tests/utils/object.test.js b/test/unit-tests/utils/object.test.js
@@ -79,7 +79,8 @@ describe('object', function () {
     })
 
     it('should throw an error in case of an unsupported type', function () {
-      assert.throws(function () { clone(/a regexp/) }, /Cannot clone/)
+      assert.throws(function () { clone(/a regexp/) }, /Cannot clone: unknown type of value \(value: \/a regexp\/\)/)
+      assert.throws(function () { clone(() => 42) }, /Cannot clone: unknown type of value \(value: \(\) => 42\)/)
     })
   })