Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantile-refactor #3003

Merged
merged 31 commits into from
Sep 20, 2023
Merged

Quantile-refactor #3003

merged 31 commits into from
Sep 20, 2023

Conversation

dvd101x
Copy link
Collaborator

@dvd101x dvd101x commented Jul 29, 2023

Just a refactor, no new features

dvd101x and others added 24 commits April 24, 2023 16:40
@dvd101x
Included math to syntax when missing
104310f
Included solveODE
431ee46
renamed initialStep as firstStep
1475b41
Included tests for solveODE
b4cac47
Test the full state instead of the final state
ca78866
Fixed issue with tolerance
bc0dd3f
@dvd101x
Merge branch 'develop' into master
ffc5a2f
@dvd101x
Added unit signature for y0
35a875e
@dvd101x
Included units test also for y0
9eb77ac
@dvd101x
Included embedded docs and more tests
727c34e
@dvd101x
Included error for tspan
9873270
@dvd101x
It works with bignumbers
8071e91
@dvd101x
reduced calling bignumber
b364fc5
@dvd101x
extended the search for bignumbers
d2a9cb8
@dvd101x
The jsdocs is less ambiguous
6f56580
@dvd101x
included tests for step options
9448e88
@dvd101x
Allowed for 0 minStep
a827c7b
@dvd101x
Optimization to avoid checking the sign every step
61f063f
@josdejong
Merge branch 'develop' into master
9d84f1b
@josdejong
Merge branch 'develop' into master
1552ddb
@dvd101x
refactor
41bd5c8
@dvd101x
Merge branch 'josdejong:develop' into quantile-refactor
034a894
@dvd101x
Typo
c9517b0
@dvd101x
removed unnecesary error
8e4d899
josdejong
josdejong reviewed Aug 23, 2023
View reviewed changes
Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, way better like this. We can merge this PR as, but I made one inline comment with an idea for further improvement. Can you have a look at that?

src/function/statistics/quantileSeq.js Outdated Show resolved Hide resolved
@josdejong
Copy link
Owner

I merged #3002, we now have a merge conflict here, can you also resolve that? Thanks!

@dvd101x
Copy link
Collaborator Author

dvd101x commented Sep 17, 2023

I just noticed that it's embedded docs are not working since #3002

I will try to fix it in here and then work on #2973 to catch cases like this

@josdejong
Copy link
Owner

Thanks for the updates David! Merging the logic of number and BigNumber worked out really nicely!

@josdejong josdejong merged commit dcf12c4 into josdejong:develop Sep 20, 2023
7 checks passed
@josdejong
Copy link
Owner

The refactor is published now in v11.11.1, thanks again David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josdejong josdejong josdejong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvd101x @josdejong