Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed matrix issue in correlation function + error handling #3030

Merged
merged 10 commits into from
Sep 20, 2023
Merged

fixed matrix issue in correlation function + error handling #3030

merged 10 commits into from
Sep 20, 2023

Conversation

vrushaket
Copy link
Contributor

Hi @josdejong,
This PR will fix issue #3025 please check.

josdejong
josdejong reviewed Sep 15, 2023
View reviewed changes
Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! I like all the extra validations and the unit tests for that, thanks. I made two inline comments, can you have a look at that?

src/function/statistics/corr.js Show resolved Hide resolved
src/function/statistics/corr.js Outdated Show resolved Hide resolved
@vrushaket
Copy link
Contributor Author

@josdejong changes has been made. please have a look.

@josdejong
Copy link
Owner

Thanks this looks 👌

@josdejong josdejong merged commit abf9c9f into josdejong:develop Sep 20, 2023
7 checks passed
@gwhitney gwhitney mentioned this pull request Oct 4, 2023
Closed
@josdejong
Copy link
Owner

The fix is published now in v11.11.2. Thanks again Vrushaket!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josdejong josdejong josdejong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrushaket @josdejong