feat: add causal parameter to prevent lookahead bias #95
+33
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
fvg()function usesshift(-1)to look at the next bar's high/low, andswing_highs_lows()usesshift(-(swing_length//2))to look forward. This creates lookahead bias that makes these indicators unsuitable for backtesting or live trading without adjustment.This PR adds a
causal=Falseparameter to both functions:causal=True,fvg()shifts all outputs forward by 1 barcausal=True,swing_highs_lows()shifts outputs forward byswing_lengthbarsThis ensures signals only appear when they would realistically be known, making the indicators suitable for causal backtesting.
Usage
Note
This PR also includes the read-only buffer fix from #94.
Test plan