Improve development workflow #547
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the general idea! Let me know when it should be usable, I will test it out then. |
|
Would you be able to split this PR up in smaller changes? |
|
@jovandeginste Yes, I could do that. I will probably come back to it next week as I am currently a bit busy. |
|
The minor changes are now split into separate PRs. |
|
All the smaller PR's are now merged, thanks for this! |
bastianjoel
force-pushed
the
docker-compose-dev-workflow
branch
from
e14ea41 to
6d82d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I aim to address some issues I encountered while setting up a development environment for this project.
templ version mismatch (#558)
When generating template files, I encountered an issue where the version installed by
make install-depsgenerated files that were incompatible with the current templ version in use.To fix this, the version from
go.modis now installed bymake install-deps.easier setup
To make the overall setup of this project easier, I added a
docker-composefile for development.With this, the whole setup can be started for development by just running
make dev-dockerwithout installing any dependencies.docker image version pinning (#559)
Without version pinning, this repository can get unbuildable if there are breaking changes on those images. To prevent this, I added version numbers to the used docker images and also updated the
depandabot.ymlto also open PRs for updates on docker images.Other minor changes
assetdir directly on development #560)go.mod(Align templ version with version from go.mod #558)While still in draft, I am already open to feedback.